fix: shellCmd to Debug and stderr/stdout to Info logs#129
Open
cazeaux wants to merge 2 commits into
Open
Conversation
cazeaux
requested review from
humoflife,
jastang and
stevendborrelli
as code owners
cazeaux
force-pushed
the
fix-logs
branch
2 times, most recently
from
776599d to
df714f8
Compare
Member
|
Hello @cazeaux. Thank you for the PR! Can you sign the DCO? Also can you provide some information on your testing? |
Signed-off-by: Stéphane Cazeaux <stephane.cazeaux@orange.com>
Signed-off-by: Stéphane Cazeaux <stephane.cazeaux@orange.com>
Author
|
Hello @stevendborrelli Thank you for the feedback. DCO is done. I have added unit tests to check the produced logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #128
This implementation proposes a simple change to send
shellCmdtoDebuglogs andstdout/stderrtoInfologs.I remain open to any other suggestion.
I have:
contribution process. Also see docs.