Skip to content

perf: bulk-copy path segments in to_file_path (unix) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crowlbot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: bulk-copy path segments in to_file_path (unix) #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion url/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3086,7 +3086,11 @@ fn file_url_segments_to_pathbuf(

for segment in segments {
bytes.push(b'/');
bytes.extend(percent_decode(segment.as_bytes()));
// `percent_decode(..).into()` yields a `Cow::Borrowed` when the segment
// has nothing to decode (no `%`), which is the common case; copying the
// slice in bulk is much faster than the byte-at-a-time decode iterator.
let decoded: Cow<'_, [u8]> = percent_decode(segment.as_bytes()).into();
bytes.extend_from_slice(&decoded);
}

// A windows drive letter must end with a slash.
Expand Down