Repository navigation
ci: run the sandbox tests and real scans on an ARM64 runner - #1259
Merged
Merged
Conversation
Deploying edgewatch with
|
| Latest commit: |
3bd223b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56fab8a2.edgewatch-cpd.pages.dev |
| Branch Preview URL: | https://ci-arm64-sandbox.edgewatch-cpd.pages.dev |
crypt0rr
force-pushed
the
ci/arm64-sandbox
branch
from
October 8, 2026 12:33
028d7db to
3bd223b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
A new CI job,
arm64-sandbox, on GitHub'subuntu-24.04-armrunners.The release publishes an ARM64 image, but its sandbox never ran on an ARM64 kernel:
containerjob builds the ARM64 image only under QEMU, where neither the seccomp filter nor Landlock runs;The job does three things natively on ARM64:
go test -raceforinternal/sandbox,internal/scanner, andinternal/notify. This includes installing the real seccomp filter on a locked thread, the Landlock thread andsandbox-exectests, and the notifier certificate checks.mainlike the other scopes../scripts/verify-scanner-sandbox.shagainst that image:Test fix the new job surfaced
The first ARM64 run failed one scanner test with
fork/exec .../edgewatch: text file busy.The scanner sandbox tests write fake executables while parallel tests fork. A child forked while a script is still open for writing holds that descriptor until it executes its own program, so running the script fails with ETXTBSY (golang/go#22315).
The tests now write their scripts while holding
syscall.ForkLockshared. Go forks only while holding it exclusively, so no fork can happen in that window. 30 consecutive-raceruns of those tests pass.Notes
arm64-sandboxis not a required check yet. Branch protection still requiresfrontend,test, andcontainer. Making it required is a repository setting I have not changed.container-hardening.mdand theAGENTS.mdvalidation table now mention the ARM64 run.Validation
node --test scripts/release-workflow.test.mjspasses; the workflow still parses, with the new job betweencontainerandrelease-cache.GOARCH=arm64 go vetandgo test -csucceed for the three packages andcmd/edgewatch.npm --prefix docs run build