Repository navigation
feat: add provider-aware notification setup - #1263
Merged
Merged
Conversation
Deploying edgewatch with
|
| Latest commit: |
2616880
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://971977a3.edgewatch-cpd.pages.dev |
| Branch Preview URL: | https://feat-notification-provider-b.edgewatch-cpd.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notification setup currently requires a complete Shoutrrr URL. Add SMTP, Discord webhook, and ntfy forms to the unit and platform consoles so administrators can enter familiar provider details, while retaining Advanced Shoutrrr URL for other providers.
Both destination APIs accept an additive structured
configinput. The backend validates it with the pinned Shoutrrr parser and writes through the existing encrypted, write-only destination operations. Existing URL clients, password confirmation, revisions, routing, and queued-alert behavior remain compatible. Credential edits replace the complete configuration; test-send feedback asks the recipient to confirm arrival.Update the notification, first-scan, security, and API compatibility guides for v0.31.0. No database migration or runtime configuration change is required.
Validation
go test -race -timeout=25m ./...andgo vet ./...passed.The docs dependency audit retains its documented 10 moderate build-tool findings; govulncheck reports no reachable vulnerabilities. Required CI coverage and container jobs must pass before merging and tagging.