Fix critical auth: send access-token header instead of Authorization: Bearer#4
Merged
pimfeltkamp merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
Critical: every authenticated request was being rejected by the AWS API Gateway in front of api.cryptohopper.com/v1/*. Switching to access-token: <token> as documented in the official Cryptohopper API docs and used by the legacy iOS/Android SDKs. Bump to 0.4.0a2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 27, 2026
The Exchange and Marketplace sections claimed those endpoints accepted anonymous calls. The auth-header fix in this PR establishes that EVERY endpoint on api.cryptohopper.com/v1/* requires a real token (the AWS API Gateway has no anonymous routes), so the README labels were misleading. Replaces them with comments that match reality.
Contributor
Author
|
Pushed a small follow-up commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Critical bug: every authenticated request currently fails. The transport sends
Authorization: Bearer <token>, which the AWS API Gateway in front ofapi.cryptohopper.com/v1/*rejects (405 Missing Authentication Token).Cryptohopper's Public API v1 uses
access-token: <token>. Switching the SDK to send that.Confirmation
cryptohopper-ios-sdkandcryptohopper-android-sdkboth sendaccess-tokenfor v1 callscode-samples/curl/README.md—-H "access-token: [ACCESS TOKEN]"Changes
src/cryptohopper/_client.py:204— header name change with explanatory commenttests/test_client.py:24— assertion updated; verified locally with a freshpip install -e .CHANGELOG.md—0.4.0a2entry under "Fixed"_version.py+pyproject.tomlbumped to0.4.0a2Compatibility
No public-API change. Same caller-facing surface; only the wire-level header changes.
Test plan
pytest— 60/60 passCRYPTOHOPPER_TOKEN=<real> python -c "from cryptohopper import CryptohopperClient; print(CryptohopperClient(api_key=...).user.get())"should now succeed where it would have 405'dCross-reference
Tracking: cryptohopper-resources#9. Sister PRs landing for Node/Go/Ruby/Rust/PHP/Dart/Swift in this same iter.