Fix critical auth: send access-token header instead of Authorization: Bearer#3
Merged
pimfeltkamp merged 3 commits intomainfrom Apr 28, 2026
Merged
Conversation
Critical: every authenticated request was being rejected by the AWS API Gateway in front of api.cryptohopper.com/v1/*. Switching to access-token: <token> as documented in the official Cryptohopper API docs and used by the legacy iOS/Android SDKs. Bump to 0.1.0.pre.alpha.2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Exchange section claimed the endpoints accepted anonymous calls. The auth-header fix in this PR establishes that EVERY endpoint on api.cryptohopper.com/v1/* requires a real token (the AWS API Gateway has no anonymous routes), so the README label was misleading. Replaces it with a comment that matches reality.
Contributor
Author
|
Pushed a small follow-up commit ( |
…Association
RuboCop's `Lint/AmbiguousBlockAssociation` flagged the `.with { … }`
block — without explicit parens, Ruby's parser binds the block to the
inner method, not the outer `expect(…).to(…)`. RuboCop is conservative
here: the binding actually was correct, but the warning is still
correctable. Wrapping the matcher in parens makes the association
explicit and lets `--fail-level W` pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: cryptohopper-resources#9. Sister PRs landing for Node/Python/Go/Rust/PHP/Dart/Swift in this same iter.
The transport sent
Authorization: Bearer <token>which the AWS API Gateway in front ofapi.cryptohopper.com/v1/*rejects with405 Missing Authentication Token— the gateway routesAuthorizationto a SigV4 parser. The Public API v1 usesaccess-token: <token>instead. Confirmed via the live API docs and the legacy iOS/Android SDKs.Changes:
lib/cryptohopper/client.rb:139— header switched, comment addedspec/cryptohopper/client_spec.rb— assertions updated; new spec verifyingAuthorizationis unsetVERSION+ CHANGELOG bumped to0.1.0.pre.alpha.2No public-API change.