Add image and video thumbnails in file browser #638
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| package org.cryptomator.presentation.util | ||
|
|
||
| import android.content.Context | ||
| import android.graphics.Bitmap | ||
| import android.graphics.BitmapFactory | ||
| import android.media.MediaMetadataRetriever | ||
| import android.os.Handler | ||
| import android.os.Looper | ||
| import android.widget.ImageView | ||
| import org.cryptomator.data.repository.DispatchingCloudContentRepository | ||
| import org.cryptomator.domain.usecases.ProgressAware | ||
| import org.cryptomator.presentation.model.CloudFileModel | ||
| import org.cryptomator.util.file.LruFileCacheUtil | ||
| import java.io.ByteArrayOutputStream | ||
| import java.io.File | ||
| import java.io.FileOutputStream | ||
| import java.io.IOException | ||
| import java.util.concurrent.Executors | ||
| import javax.inject.Inject | ||
| import javax.inject.Singleton | ||
| import timber.log.Timber | ||
|
|
||
| @Singleton | ||
| class ThumbnailUtil @Inject constructor( | ||
| context: Context, | ||
| private val cloudContentRepository: DispatchingCloudContentRepository, | ||
| ) { | ||
|
|
||
| private val executor = Executors.newFixedThreadPool(3) | ||
| private val mainHandler = Handler(Looper.getMainLooper()) | ||
| private val thumbnailDir: File = LruFileCacheUtil(context).resolve(LruFileCacheUtil.Cache.THUMBNAILS) | ||
|
|
||
| init { | ||
| thumbnailDir.mkdirs() | ||
| } | ||
|
|
||
| fun loadThumbnail(file: CloudFileModel, target: ImageView) { | ||
| val cacheKey = cacheKey(file) | ||
| target.tag = cacheKey | ||
|
|
||
| val cachedFile = File(thumbnailDir, "$cacheKey.jpg") | ||
|
|
||
| executor.execute { | ||
| runCatching { | ||
| val bitmap = if (cachedFile.exists()) { | ||
| BitmapFactory.decodeFile(cachedFile.absolutePath) | ||
| } else { | ||
| when (file.icon) { | ||
| FileIcon.MOVIE -> generateVideoThumbnail(file, cachedFile) | ||
| else -> generateImageThumbnail(file, cachedFile) | ||
| } | ||
| } ?: return@execute | ||
|
|
||
| mainHandler.post { | ||
| if (target.tag == cacheKey) { | ||
| target.setImageBitmap(bitmap) | ||
| } | ||
| } | ||
| }.onFailure { e -> | ||
| Timber.tag("ThumbnailUtil").w(e, "Failed to generate thumbnail for ${file.name}") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fun cancelLoad(target: ImageView) { | ||
| target.tag = null | ||
| } | ||
|
|
||
| private fun generateImageThumbnail(file: CloudFileModel, cachedFile: File): Bitmap? { | ||
| val bytes = downloadToByteArray(file) ?: return null | ||
| val bitmap = decodeScaledBitmap(bytes) ?: return null | ||
| saveThumbnail(bitmap, cachedFile) | ||
|
Comment on lines
+69
to
+72
There was a problem hiding this comment. Current image path loads entire files into heap before sampling. Downloading full image bytes first defeats memory savings from Also applies to: 95-100 🤖 Prompt for AI Agents |
||
| return bitmap | ||
| } | ||
|
|
||
| private fun generateVideoThumbnail(file: CloudFileModel, cachedFile: File): Bitmap? { | ||
| val tmpFile = File(thumbnailDir, "${cacheKey(file)}.tmp") | ||
| val retriever = MediaMetadataRetriever() | ||
| return try { | ||
| downloadToFile(file, tmpFile) ?: return null | ||
| retriever.setDataSource(tmpFile.absolutePath) | ||
| val frame = retriever.getFrameAtTime(0, MediaMetadataRetriever.OPTION_CLOSEST_SYNC) | ||
| ?: return null | ||
| val bitmap = scaleBitmap(frame) | ||
| saveThumbnail(bitmap, cachedFile) | ||
| bitmap | ||
| } finally { | ||
| retriever.release() | ||
| tmpFile.delete() | ||
| } | ||
| } | ||
|
|
||
| private fun downloadToByteArray(file: CloudFileModel): ByteArray? { | ||
| return try { | ||
| ByteArrayOutputStream().also { out -> | ||
| cloudContentRepository.read(file.toCloudNode(), null, out, ProgressAware.NO_OP_PROGRESS_AWARE_DOWNLOAD) | ||
| }.toByteArray() | ||
| } catch (e: Exception) { | ||
| Timber.tag("ThumbnailUtil").w(e, "Download failed for ${file.name}") | ||
| null | ||
| } | ||
| } | ||
|
|
||
| private fun downloadToFile(file: CloudFileModel, dest: File): File? { | ||
| return try { | ||
| FileOutputStream(dest).use { out -> | ||
| cloudContentRepository.read(file.toCloudNode(), null, out, ProgressAware.NO_OP_PROGRESS_AWARE_DOWNLOAD) | ||
| } | ||
| dest | ||
| } catch (e: Exception) { | ||
| Timber.tag("ThumbnailUtil").w(e, "Download failed for ${file.name}") | ||
| null | ||
| } | ||
| } | ||
|
|
||
| private fun decodeScaledBitmap(bytes: ByteArray): Bitmap? { | ||
| val opts = BitmapFactory.Options().apply { inJustDecodeBounds = true } | ||
| BitmapFactory.decodeByteArray(bytes, 0, bytes.size, opts) | ||
| if (opts.outWidth <= 0 || opts.outHeight <= 0) return null // unsupported format e.g. SVG | ||
| opts.inSampleSize = computeSampleSize(opts.outWidth, opts.outHeight) | ||
| opts.inJustDecodeBounds = false | ||
| return BitmapFactory.decodeByteArray(bytes, 0, bytes.size, opts) | ||
| } | ||
|
|
||
| private fun scaleBitmap(src: Bitmap): Bitmap { | ||
| val sampleSize = computeSampleSize(src.width, src.height) | ||
| if (sampleSize == 1) return src | ||
| return Bitmap.createScaledBitmap(src, src.width / sampleSize, src.height / sampleSize, true) | ||
| } | ||
|
|
||
| private fun computeSampleSize(width: Int, height: Int): Int { | ||
| var n = 1 | ||
| while (minOf(width, height) / (n * 2) >= THUMBNAIL_PX) n *= 2 | ||
| return n | ||
| } | ||
|
|
||
| private fun saveThumbnail(bitmap: Bitmap, dest: File) { | ||
| try { | ||
| FileOutputStream(dest).use { bitmap.compress(Bitmap.CompressFormat.JPEG, 80, it) } | ||
| } catch (e: IOException) { | ||
| Timber.tag("ThumbnailUtil").w(e, "Could not save thumbnail to disk") | ||
| } | ||
| } | ||
|
|
||
| private fun cacheKey(file: CloudFileModel): String = | ||
| "${file.path}_${file.size}".hashCode().toString().replace('-', 'n') | ||
|
|
||
| companion object { | ||
| private const val THUMBNAIL_PX = 144 | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.