Support for encrypted UserDefinedAttributeView#156
Draft
overheadhunter wants to merge 6 commits intodevelopfrom
Draft
Support for encrypted UserDefinedAttributeView#156overheadhunter wants to merge 6 commits intodevelopfrom
overheadhunter wants to merge 6 commits intodevelopfrom
Conversation
infeo
reviewed
Jan 9, 2023
Member
infeo
left a comment
infeo
left a comment
There was a problem hiding this comment.
Looks good.
Regarding handling of too long attributes: I'm totally fine by defining a limit and throw an IOException if the limit is exceeded. But I honstely don't know, what an appropiate limit would be.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
c9r.+ base64url-encoded siv-encrypted attribute namesThere is no shortening. TBD: How to deal with too long attribute names?
This PR replaces the stale branch feature/47-user-attr.