Skip to content

Fix issue #155#180

Merged
teodutu merged 1 commit into
cs-pub-ro:mainfrom
DaMiAnThEk:lab03-fix-issue-155
May 9, 2026
Merged

Fix issue #155#180
teodutu merged 1 commit into
cs-pub-ro:mainfrom
DaMiAnThEk:lab03-fix-issue-155

Conversation

@DaMiAnThEk
Copy link
Copy Markdown

@DaMiAnThEk DaMiAnThEk commented May 8, 2026

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Fixes #155

Removed the direct return statement from the conditional branch in binary_search() by redirecting execution to a dedicated label (not_found).

Copy link
Copy Markdown

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. To pass the checkpatch CI, you need to reword your commit to add a description and the signature. To do so, you can run the following:

$ git commit --amend -s
# This will open your default editor and there you'll see the signed-off-by line.
# Add a commit description below the commit title.

$ git push -f  # Update the remote repo

Remove direct statement from the conditional branch
in binary_search() by redirecting execution to the
not_found label.

Signed-off-by: Damian Tanasa <damiantanasa10022005@gmail.com>
@DaMiAnThEk DaMiAnThEk force-pushed the lab03-fix-issue-155 branch from 22ad18d to 2fc468f Compare May 9, 2026 07:29
@teodutu teodutu merged commit 0e40990 into cs-pub-ro:main May 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lab03: Binary Search: Solution contains direct return from if

2 participants