Repository navigation
Conversation
Owner
|
Thanks for your PR, it looks good and I'll merge it now. Since I had a release a couple of days ago, is it ok for you to wait a few days for the next release? Until then you can give it a try by referencing to the master branch of this repository. Thanks, |
sricharanreddycheruku
deleted the
agent2-check-requests-on-context-exit
branch
October 8, 2026 14:06
Contributor
Author
|
Thanks, Yes, waiting a few days for the next release is fine. Thanks for reviewing and merging the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wait()stops when its first stopping condition is met, so unexpected requests sent after all ordered requests complete are not reported by that context. As proposed in #482, this addswith_check()to run the existing server checks when a block exits normally.The helper reports unexpected requests and response-handler errors without changing
wait()semantics. It yields the server instance and preserves exceptions raised inside the block. It does not wait for requests or stop the server. The how-to documentation and a Reno release note describe these semantics.Four regression tests cover successful ordered requests, an unexpected request after the expected requests, handler errors, and preservation of a client-side exception. All four fail on the original source because the helper is absent; all pass with this change.
Validation on Linux with Python 3.12.14 and the locked development dependencies installed using Poetry 2.1.1:
pytest -q tests --release— 154 passed, 3 skipped, 2 xfailed; the existing tar-extraction warning remains.pytest -q tests --ssl— 1 passed, 158 skipped by the SSL selection.make precommitandgit diff --check: passed.make doc: passed. Its 59 warnings also occur with unchanged source; this change introduces none.Fixes #482