Selenium rewrite #233
Open
Selenium rewrite #233
+23,412
−309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we can ever identify the Edge version reliably, then it will be possible to uncomment this and support Edge 13.x once again. This will be by only having the appropriate flag present for newer versions.
This was a file I had forgotten to save when performing the previous commit.
Adding the doctype declaration means that IE9 renders the testing web page as expected and also fires JavaScript. Further bugs might be found, but this error (where the whole testing website failed to render correctly) is now fixed.
This version of Edge will no longer use the ctrl-click method of toggling selection.
This browser does not work correctly even without the modifier key pressed. It appears that in Edge 14, Microsoft fixed a real bug relating to HTML <select multiple> but they fixed it requiring a modifier key. This commit essentially reverts the work introduced in: 191f7b2 Except that rather than leave that browser commented-out in the build matrix, this commit outright removes it.
This will prevent them from selecting an item by index and will ignore the applicable tests.
…ect-by-index Resolve & merge #25 - Old versions of Firefox cannot (de)select by index
…lements Oh dear. I had thought that Safari 11 would require command+click in order to toggle state of <select multiple> elements. The same problems I am seeing for multi-select elements, I am also seeing for single-select elements. That suggests that the problem actually has nothing to do with select elements with the multiple attribute. Right now, as far as I can tell, Safari v11 (specifically, it's webdriver) is plain incompatible with anything that changes the state of a select element. I've set up a browser flag to indicate this. If I'm lucky I'll be able to find a better solution or workaround someday.
This is a showstopper bug (not being able to read from a field).
…itions Any flags definitions related to Firefox version 52 or less can be removed, since I no longer support the browser at all.
It seems my previous attempt has not worked
* Avoid splatting a console error in a place that's unwanted * Exit with a failure code if any tests fail * Exclude the non-test web app from tests
….Screenplay into 212-selenium-rewrite
It seems that the issue using the nunit 3 endpoint persists. Look at the history of this file for a now-deleted comment that links to more info about that. It seems that after 6 months, it's still not resolved. The symptom is uploading an nunit 3 test result file which includes test durations expressed in scientific notation causes HTTP 500 errors from the Appveyor endpoint.
….Screenplay into 212-selenium-rewrite
The tests param is unsupported in the .NET scanner.
Also exclude docco from Sonar analysis
This is the "multi process model" issue with NUnit. The test method parameters were being resolved in the test-building process and not the test-running process. This caused issues with things like event subscriptions because the publishers (actors) were publishing events to a different event bus than the one which had subcscribers.
This includes some changes to the way assets work.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR for #212 and related issues. It introduces a complete rewrite of the Selenium library, which has been imported (with history) from CSF.Screenplay.Selenium.