Implement pass_defines (fixed)#110
Open
oriceemple wants to merge 1 commit intocsmith-project:masterfrom
Open
Conversation
Closed
Member
|
continuing the discussion, my opinion is that depending on clang is perfectly OK since we already expect clang-format to exist |
Member
|
also, as Eric says, squashing at the end is the preferred workflow. github also has an auto-squash on merge feature that I haven't tried yet. |
Member
|
It's an interesting approach. Can you share some examples where this approach works but where it wasn't possible to preprocess before running C-Reduce? |
Contributor
Author
|
I can't give exact details, but I can explain where pass_defines helps me:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.