Conversation
Eight comments across five files send a reader to awx/settings/production.py and awx/settings/defaults.py to see what they are overriding. Neither path exists any more: the package rename moved them to ascender/settings/, and awx/ is a shim of one file. A comment that names a file which is not there is worse than no comment, because the reader assumes they are looking in the wrong place rather than that the note is stale. Both paths checked against the platform's main before being written. Comments only. Nothing here changes what is loaded or when.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight comments across five files send a reader to
awx/settings/production.pyandawx/settings/defaults.pyto see what they are overriding.Neither path exists any more. The package rename moved them to
ascender/settings/, andawx/is a shim of one file. A comment naming a file that is not there is worse than no comment: the reader assumes they are looking in the wrong place rather than that the note is stale.Both replacement paths were checked to exist on the platform's
mainrather than assumed.Comments only. Nothing changes what is loaded or when, and the changed YAML parses.
Four of the five files are also touched by #247, #250 or #255, on different lines.