fix: follow the platform's renamed job folder and session cookie - #73
Merged
Merged
Conversation
The platform renamed the prefix on a job's private data directory from awx_ to ascender_, so the volume mount this looks for to find the controller's copy is /tmp/ascender_<id> on a current server and /tmp/awx_<id> on an older one. Both are accepted rather than swapping one for the other. A client is not installed alongside the server it talks to and there is no version negotiation here, so pinning either name alone breaks against half the releases, and the symptom is a RuntimeError saying no private_data_dir could be found rather than anything naming a version mismatch.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The platform renamed SESSION_COOKIE_NAME from awx_sessionid, so the cookie WSClient sends had the wrong name. Unlike the HTTP side this one cannot take both. Connection reads the name from the X-API-Session-Cookie-Name header at login and so is right against any release, but the websocket cookie is sent rather than read and has to be the single name the server expects. The default follows the current server, and the comment now says that a caller holding a Connection should pass its session_cookie_name rather than rely on the default, which is the only thing that is correct against an older one.
blaipr
changed the title
cigamit
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two server-side names moved in ctrliq/ascender#997, and this client reads both.
The job private data directory.
JOB_FOLDER_PREFIXwent fromawx_toascender_, so the volume mount this looks for is/tmp/ascender_<id>on a current server and/tmp/awx_<id>on an older one. Both are accepted rather than swapping one for the other: a client is not installed alongside the server it talks to and there is no version negotiation here, so pinning either name alone breaks against half the releases, and the symptom is aRuntimeErrorsaying noprivate_data_dircould be found rather than anything naming a version mismatch.The session cookie.
SESSION_COOKIE_NAMEwent fromawx_sessionidtoascender_sessionid. This one cannot take both:Connectionalready reads the name from theX-API-Session-Cookie-Nameheader at login and so is correct against any release, but the websocket cookie is sent rather than read and has to be the single name the server expects. The default follows the current server, and the comment now says that a caller holding aConnectionshould pass itssession_cookie_nameinstead of relying on the default, which is the only thing correct against an older one.