Conversation
The two imports the AWX migration script makes to rebuild role parentage name the platform's Python package. ctrliq/ascender#988 makes every module answer to both names, aliased to one module object rather than imported twice, so this is the same code either way. Needs the Ascender release carrying that alias, since this repository installs a pinned ASCENDER_VERSION and the new path does not resolve before it. The awx_migrate_ascender role keeps its name. It migrates from AWX.
Collaborator
|
This will wait until we have released the new Ascender version. A lot of users do a git pull from main for this repo. |
Contributor
Author
|
Agreed, same as the ascender-install one.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two imports
awx_migrate.sh.j2makes to rebuild role parentage name the platform's Python package:awx.main.models.rbacandawx.main.migrations._rbac.ctrliq/ascender#988 makes every module answer to both names, aliased to one module object rather than imported twice, so this is the same code either way. It is a move off the old name rather than a fix.
Ordering
Needs the Ascender release carrying that alias. This repository installs a pinned
ASCENDER_VERSION, so the new path does not resolve before it.The
awx_migrate_ascenderrole keeps its name. It migrates from AWX, so AWX is the right word.The sibling change for ascender-install is #247.