Add configurable proxy timeout via annotations#154
Open
PhoenixSolutionsGroup wants to merge 2 commits intoctrox:mainfrom
Open
Add configurable proxy timeout via annotations#154PhoenixSolutionsGroup wants to merge 2 commits intoctrox:mainfrom
PhoenixSolutionsGroup wants to merge 2 commits intoctrox:mainfrom
Conversation
ctrox
requested changes
Feb 18, 2026
Owner
ctrox
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good but I think to fix the issue described you also need to make the connectTimeout configurable as that is most likely more relevant while the container is being restored. The proxyTimeout only comes into play after the restored container was able to accept the connection. Would be great if you could also add that.
Author
|
Just added the timeout and created |
Owner
|
Oh almost forgot, can you also add the new annotaions to the docs? Other than that it looks good to merge, I just triggered the CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zeropod.ctrox.dev/proxy-timeoutannotation to make the activator's proxy timeout configurableprobe-buffer-sizeMotivation
When a restored app depends on a downstream service that also needs to wake up (e.g. a hibernated database), the response can take longer than 5s. The hardcoded timeout kills the proxy conn>
Usage
Test plan
Closes #153