test(testing-drivers): Cover window function over measure#11156
test(testing-drivers): Cover window function over measure#11156MazterQyou wants to merge 1 commit into
Conversation
|
Claude finished @MazterQyou's task in 38s —— View job Code ReviewVerdict: LGTM — 0 high, 0 medium, 1 low (nit)
Summary Solid, narrowly-scoped test addition. The new Skip-list entries for BigQuery, Databricks, MSSQL, and MySQL look correctly placed in both the regular Nits
Nothing blocking. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #11156 +/- ##
===========================================
- Coverage 83.70% 59.13% -24.57%
===========================================
Files 257 217 -40
Lines 79465 17548 -61917
Branches 0 3572 +3572
===========================================
- Hits 66513 10377 -56136
+ Misses 12952 6655 -6297
- Partials 0 516 +516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b78f7e6 to
fc7d0e9
Compare
|
Claude finished @MazterQyou's task in 59s —— View job Code ReviewVerdict: LGTM — 0 high, 0 medium, 0 low Details
Summary Narrowly-scoped test addition covering Snapshots — all 5 supported engines (Athena/S3, ClickHouse, Postgres, Redshift, Snowflake) produce identical quarterly running totals (5 → 18 → 24 → 44), confirming the window-over-measure semantics are consistent across drivers. Skip lists — entries correctly placed:
Code quality / Security / Performance — N/A for test-only changes; no production paths touched. Notes
Nothing blocking. |
fc7d0e9 to
6ee1443
Compare
|
Claude finished @MazterQyou's task in 21s —— View job Code ReviewVerdict: LGTM — 0 high, 0 medium, 0 low Details
Summary Test-only change adding Snapshots — all supported engines (Athena/S3, ClickHouse, Postgres, Redshift, Snowflake variants) produce identical quarterly running totals (5 → 18 → 24 → 44), confirming consistent semantics. Skip lists — correctly placed:
Code quality / Security / Performance — N/A for test-only changes; no production paths touched. Testing / Docs — no docs required (test-only). Nothing blocking. |
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
6ee1443 to
f36fb80
Compare
|
Claude finished @MazterQyou's task in 21s —— View job Code ReviewVerdict: LGTM — 0 high, 0 medium, 0 low Details
Summary Test-only change adding Snapshots — all supported engines (Athena/S3, ClickHouse, Postgres, Redshift, Snowflake variants) produce identical quarterly running totals (5 → 18 → 24 → 44), confirming consistent semantics. Skip lists — correctly placed:
Code quality / Security / Performance — N/A for test-only changes; no production paths touched. Testing / Docs — no docs required (test-only). Nothing blocking. |
Check List
Description of Changes Made
This PR adds a test covering window functions over measures.