Skip to content

test(testing-drivers): Cover window function over measure#11156

Open
MazterQyou wants to merge 1 commit into
masterfrom
testing-drivers/window-function-over-measure
Open

test(testing-drivers): Cover window function over measure#11156
MazterQyou wants to merge 1 commit into
masterfrom
testing-drivers/window-function-over-measure

Conversation

@MazterQyou

Copy link
Copy Markdown
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds a test covering window functions over measures.

@MazterQyou MazterQyou requested a review from a team as a code owner June 24, 2026 16:47
@github-actions github-actions Bot added the javascript Pull requests that update Javascript code label Jun 24, 2026
@claude

claude Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Claude finished @MazterQyou's task in 38s —— View job


Code Review

Verdict: LGTM — 0 high, 0 medium, 1 low (nit)
  • Review test addition in testQueries.ts
  • Review fixture skip lists across drivers
  • Review snapshot updates

Summary

Solid, narrowly-scoped test addition. The new SQL API: Window function over measure (running total) exercises SUM(MEASURE(count)) OVER (...) against BigECommerce, with a deterministic year filter (2020) and ORDER BY 1 ASC NULLS FIRST for stable snapshot output. Snapshots for the five supported engines (Athena/S3, ClickHouse, Postgres, Redshift, Snowflake) look consistent — same 4 quarterly rows and matching running totals (5, 18, 24, 44).

Skip-list entries for BigQuery, Databricks, MSSQL, and MySQL look correctly placed in both the regular skip and tesseractSkip arrays where applicable.

Nits

  • packages/cubejs-testing-drivers/fixtures/bigquery.json:254 — a trailing whitespace was introduced on the closing line:
    "querying BigECommerce: two multi-stage branches sharing one pre-aggregation" 
    
    Worth stripping to keep the file clean.
  • Optional: consider also adding the test name to mssql.json's tesseract skip list section if Tesseract is expected to fail there too (currently it's added to both base skip sections at lines 199 and 251 — confirm that matches the two skip arrays' intent).

Nothing blocking.
· branch testing-drivers/window-function-over-measure

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.13%. Comparing base (f9398ab) to head (f36fb80).
⚠️ Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f9398ab) and HEAD (f36fb80). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f9398ab) HEAD (f36fb80)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11156       +/-   ##
===========================================
- Coverage   83.70%   59.13%   -24.57%     
===========================================
  Files         257      217       -40     
  Lines       79465    17548    -61917     
  Branches        0     3572     +3572     
===========================================
- Hits        66513    10377    -56136     
+ Misses      12952     6655     -6297     
- Partials        0      516      +516     
Flag Coverage Δ
cube-backend 59.13% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou force-pushed the testing-drivers/window-function-over-measure branch from b78f7e6 to fc7d0e9 Compare June 30, 2026 18:50
@claude

claude Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @MazterQyou's task in 59s —— View job


Code Review

Verdict: LGTM — 0 high, 0 medium, 0 low

Details
  • Reviewed testQueries.ts test addition
  • Reviewed fixture skip lists (bigquery, databricks-jdbc, mssql, mysql)
  • Reviewed snapshots across all 5 supported engines
  • Verified prior nit (trailing whitespace in bigquery.json) — already cleaned up

Summary

Narrowly-scoped test addition covering SUM(MEASURE(count)) OVER (...) as a running total against BigECommerce. The test (packages/cubejs-testing-drivers/src/tests/testQueries.ts:2693) uses a deterministic 2020 year filter and ORDER BY 1 ASC NULLS FIRST for stable output — good practice for snapshot determinism.

Snapshots — all 5 supported engines (Athena/S3, ClickHouse, Postgres, Redshift, Snowflake) produce identical quarterly running totals (5 → 18 → 24 → 44), confirming the window-over-measure semantics are consistent across drivers.

Skip lists — entries correctly placed:

  • bigquery.json: both skip and tesseractSkip
  • databricks-jdbc.json: both skip and tesseractSkip
  • mssql.json: both base skip sections (lines 199, 251)
  • mysql.json: both skip and tesseractSkip

Code quality / Security / Performance — N/A for test-only changes; no production paths touched.

Notes

  • The trailing-whitespace nit flagged in the prior review on bigquery.json:254 has been resolved (no " $" matches in the file).
  • No documentation changes needed (test-only).

Nothing blocking.

· branch [`testing-drivers/window-function-over-measure`](https://github.com/cube-js/cube/tree/testing-drivers/window-function-over-measure)

@MazterQyou MazterQyou force-pushed the testing-drivers/window-function-over-measure branch from fc7d0e9 to 6ee1443 Compare July 1, 2026 12:56
@claude

claude Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Claude finished @MazterQyou's task in 21s —— View job


Code Review

Verdict: LGTM — 0 high, 0 medium, 0 low

Details
  • Reviewed test addition in testQueries.ts
  • Reviewed fixture skip lists (bigquery, databricks-jdbc, mssql, mysql, oracle)
  • Reviewed snapshots across all supported engines

Summary

Test-only change adding SQL API: Window function over measure (running total) at packages/cubejs-testing-drivers/src/tests/testQueries.ts:2693. Exercises SUM(MEASURE(count)) OVER (...) over BigECommerce with a deterministic 2020 year filter and ORDER BY 1 ASC NULLS FIRST for stable snapshot output.

Snapshots — all supported engines (Athena/S3, ClickHouse, Postgres, Redshift, Snowflake variants) produce identical quarterly running totals (5 → 18 → 24 → 44), confirming consistent semantics.

Skip lists — correctly placed:

  • bigquery.json, databricks-jdbc.json, mysql.json: both skip and tesseractSkip
  • mssql.json: both base skip sections (lines 198, 252)
  • oracle.json: added to base skip (line 210) and to tesseractSkip with a clear comment ("SQL API push down not yet supported on Oracle")

Code quality / Security / Performance — N/A for test-only changes; no production paths touched.

Testing / Docs — no docs required (test-only).

Nothing blocking.

· branch [`testing-drivers/window-function-over-measure`](https://github.com/cube-js/cube/tree/testing-drivers/window-function-over-measure)

Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
@MazterQyou MazterQyou force-pushed the testing-drivers/window-function-over-measure branch from 6ee1443 to f36fb80 Compare July 3, 2026 13:32
@claude

claude Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @MazterQyou's task in 21s —— View job


Code Review

Verdict: LGTM — 0 high, 0 medium, 0 low

Details
  • Reviewed test addition in testQueries.ts
  • Reviewed fixture skip lists (bigquery, databricks-jdbc, mssql, mysql, oracle)
  • Reviewed snapshots across all supported engines

Summary

Test-only change adding SQL API: Window function over measure (running total) at packages/cubejs-testing-drivers/src/tests/testQueries.ts:2693. Exercises SUM(MEASURE(count)) OVER (...) over BigECommerce with a deterministic 2020 year filter and ORDER BY 1 ASC NULLS FIRST for stable snapshot output.

Snapshots — all supported engines (Athena/S3, ClickHouse, Postgres, Redshift, Snowflake variants) produce identical quarterly running totals (5 → 18 → 24 → 44), confirming consistent semantics.

Skip lists — correctly placed:

  • bigquery.json, databricks-jdbc.json, mysql.json: both skip and tesseractSkip
  • mssql.json: both base skip sections
  • oracle.json: base skip and tesseractSkip with clear comment ("SQL API push down not yet supported on Oracle")

Code quality / Security / Performance — N/A for test-only changes; no production paths touched.

Testing / Docs — no docs required (test-only).

Nothing blocking.

· branch [`testing-drivers/window-function-over-measure`](https://github.com/cube-js/cube/tree/testing-drivers/window-function-over-measure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant