Skip to content

docs: per-column table chart width controls#11180

Merged
igorlukanin merged 2 commits into
masterfrom
igor/cub-3033-table-chart-support-per-column-width-control
Jul 2, 2026
Merged

docs: per-column table chart width controls#11180
igorlukanin merged 2 commits into
masterfrom
igor/cub-3033-table-chart-support-per-column-width-control

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

What

Documents per-column width controls for the table chart: each column can be Fixed (a locked pixel width) or Flexible (a weight that shares the remaining table width), with bulk convert, drag-to-resize, and fit-to-content. Updates the "Column width" section and the column field-options table.

Companion to the Cube Cloud feature work (CUB-3033).

@igorlukanin igorlukanin requested a review from keydunov as a code owner June 30, 2026 13:37
@claude

claude Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 39s —— View job


Code review — docs: per-column table chart width controls

Verdict: LGTM. Docs-only change; the prose is clear, the new section is well-structured, and conventions match docs-mintlify/CLAUDE.md (Mintlify <Note> callouts, root-relative anchor links, no body H1, short paragraphs, second-person voice). No blocking issues.

Detailed review
  • Read the PR diff and surrounding table.mdx context
  • Verify Mintlify conventions (callouts, headings, links)
  • Check anchors and cross-references
  • Look for terminology drift vs. CLAUDE.md product naming
  • Surface any minor nits

What's good

  • Removing the obsolete table-level Column width row and replacing it with a pointer to the new dedicated ## Column width section avoids two competing sources of truth.
  • Both internal links ([Column width](#column-width)) resolve to the new H2 anchor that Mintlify auto-generates — verified by name.
  • <Note> is correctly used (the gray callout) for the auto-fit caveat and the pivot caveat, with the required blank lines around the inner content so the markdown renders.
  • The Flexible / Fixed framing in both the field-options table row and the dedicated section matches the actual UI controls described in the PR body, and the "weight 2 is twice as wide as weight 1" explanation is concrete and unambiguous.
  • The "drag-to-resize saves into the column's current mode" behavior is a non-obvious UX detail worth documenting and is captured here.

Minor nits (non-blocking)

  • table.mdx:67 — "the auto-fit button next to a column's width" reads slightly oddly because the noun appears twice ("auto-fit button … auto-fit again after scrolling"). Consider "the auto-fit button next to a column's width sizes it to its content and switches the column to Fixed" then in the Note "re-run auto-fit after scrolling" for a tiny readability bump. Purely stylistic.
  • table.mdx:8, :22, :103, :126, :158, :204, :239 — pre-existing TODO screenshot placeholders, not introduced by this PR. Worth a separate pass to either add the screenshots or replace with the {/* TODO: screenshot — ... */} form recommended in docs-mintlify/CLAUDE.md, but out of scope here.
  • No docs.json change is needed — this page is already registered; the new H2 just adds an in-page section.

Out of scope (FYI)

  • Code quality / security / performance / testing categories from the review template do not apply to a docs-only change.
• Branch: `igor/cub-3033-table-chart-support-per-column-width-control`

@mintlify

mintlify Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jun 30, 2026, 1:44 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@keydunov keydunov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have screenshots / videos in docs for tables?

@igorlukanin

Copy link
Copy Markdown
Member Author

I'll add screenshots / video in a bit, when the UI stops changing that much. Also, we'll have plenty of videos to reuse: https://linear.app/cube-d3/issue/CUB-3103/add-screenshots-reuse-videos-in-docs

@claude

claude Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 41s —— View job


Re-review after synchronize — still LGTM

Latest commit (8221e6b) is a naming/consistency pass on the new Column width section:

  • Renames the per-column button from Auto-fitFit to content (button label, list item, and both mentions inside the <Note> — consistent everywhere).
  • Adds a new bulk row All fit to content, correctly described as the bulk equivalent of the per-column control and noting the "rendered rows only" caveat inherits from the per-column behavior.
  • Adds the enablement conditions on All flexible / All fixed ("Enabled only when at least one column is fixed/flexible") — a nice, non-obvious UX detail.
Details
  • Terminology is now consistent across the section: "Flexible / Fixed" for modes, "Fit to content" for the sizing action — no leftover "auto-fit" occurrences (grepped the file).
  • Mintlify <Note> blocks retain the required blank lines around inner content.
  • No docs.json change needed; same in-page section.
  • Screenshots deferred per author comment (tracked in Linear CUB-3103) — reasonable given ongoing UI churn.

No blocking issues; the earlier stylistic nit on the "auto-fit … auto-fit again" wording is moot now that the phrasing changed.

• Branch: `igor/cub-3033-table-chart-support-per-column-width-control`

@igorlukanin igorlukanin merged commit c4d9c51 into master Jul 2, 2026
9 checks passed
@igorlukanin igorlukanin deleted the igor/cub-3033-table-chart-support-per-column-width-control branch July 2, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants