Enforce rechunking for sharded Icechunk store#897
Merged
tomwhite merged 4 commits intocubed-dev:mainfrom May 5, 2026
Merged
Conversation
Member
That would be good. |
Contributor
Author
|
@tomwhite sorry for my delayed changes. Could you please check if everything looks good to you? I moved the rechunking to a central place in |
tomwhite
approved these changes
May 5, 2026
Member
tomwhite
left a comment
tomwhite
left a comment
There was a problem hiding this comment.
This looks good to me!
The failures are due to Zarr changes which are unrelated to this, but would you mind rebasing to rerun the tests please?
Contributor
Author
|
@tomwhite great, thanks for approving! I rebased - hopefully the tests are successful now. |
Contributor
Author
|
@tomwhite let me try to fix the remaining issues, they did not appear in my local branch. |
Member
|
Thanks @claxn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves issue #896 by enforcing a rechunking of the input array, if the output store is sharded and the input chunks do not match the shards.
Should we add a warning to notify the users that there is a mismatch of
cubedchunks and Zarrshards?