Conversation
Member
Author
|
Split into many commits to hopefully simplify review, PTAL. I'm no expert in any of this, so I'm relying quite a bit on Fable. |
Bump @actions/core, @actions/exec, and @actions/tool-cache to their latest CommonJS majors; the newest majors are ESM-only and would require migrating the action and its tests to ESM. Bump the dev dependencies to their latest versions, with two caveats: jest 30 removed the toBeCalled matcher aliases, and TypeScript stays on 5.x since ts-jest caps it below 7.0 and 6.0 force-enables esModuleInterop, which breaks the spy-based tests. Deny the unrs-resolver postinstall script, which npm blocks with a warning and jest works fine without. Rebuild dist accordingly. The jest tests pass again with these versions. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
cue commands now require a language version in module.cue; add it via 'cue mod fix'. The genworkflows tasks generated inside the comprehension no longer have their dependency on the repoRoot exec task tracked, failing with a non-concrete stdout. Drop the indirection and write the files relative to the working directory, which is always the repo root when running cue cmd. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Replace the schemas vendored from schemastore.org under cue.mod/pkg with the cue.dev/x/githubactions module from the Central Registry, which CUE resolves and fetches automatically. This makes the vendorgithubschema command and its CI step redundant. Regenerating action.yml with CUE v0.17.1 also reorders some fields. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Use the latest actions/checkout and actions/setup-node with node 24, matching the action's new runtime, and test against CUE v0.17.1, the current latest release. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
The tests were disabled in CI when they broke with newer dependencies; they pass again, so run them in the step that so far only ran 'npm ci'. Importing src/run.ts invoked run() as a side effect, so jest ran it unmocked and core.setFailed marked the process as failed even with all tests passing. Only invoke run() when executed as the entrypoint, and rebuild dist. Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)