🎨 Palette: Add aria-hidden to decorative GitHub icon in Hero - #155
google-labs-jules[bot] wants to merge 1 commit into
Conversation
Ensure decorative GitHub SVG icon in the Hero component is hidden from screen readers to prevent redundant screen reader announcements when text label is present.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Superseded by #157 |
This branch was successfully deployed
1 participant
💡 What:
Added
aria-hidden="true"to the decorative GitHub icon (SiGithub) in the Hero component (app/components/Hero/index.tsx) and updated unit test coverage intests/unit/components/Hero/index.test.tsx.🎯 Why:
The link already includes the visible text "GitHub" and a screen-reader-only note for external navigation. Leaving the decorative icon without
aria-hidden="true"causes screen readers to redundantly announce decorative graphics or non-descriptive icon data.📸 Before/After:
Visual rendering remains clean and visually unchanged, with full keyboard focus and visual indication intact.
♿ Accessibility:
Enhanced screen reader accessibility by hiding decorative SVG markup from assistive technologies.
PR created automatically by Jules for task 17040971602993659222 started by @amrabed