Skip to content

🎨 Palette: add reload icon to error boundary action button #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

🎨 Palette: add reload icon to error boundary action button #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { useEffect } from "react";
import { Button } from "@heroui/react";
import { AlertCircle, RefreshCcw } from "lucide-react";
import { AlertCircle, RefreshCcw, RotateCcw } from "lucide-react";
import { reportError } from "@/lib/error-reporting";

export default function Error({
Expand Down Expand Up @@ -34,6 +34,7 @@ export default function Error({
onClick={() => window.location.reload()}
className="focus-ring rounded-xl px-8"
>
<RotateCcw className="h-4 w-4 mr-2" aria-hidden="true" />
Reload Page
</Button>
<Button
Expand Down
11 changes: 11 additions & 0 deletions tests/unit/app/error.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,17 @@ describe("Error component", () => {
expect(mockReset).toHaveBeenCalledTimes(1);
});

it("ensures decorative icons are hidden from screen readers", () => {
const { container } = render(
<ErrorComponent error={mockError} reset={mockReset} />
);
const svgs = container.querySelectorAll("svg");
expect(svgs.length).toBeGreaterThan(0);
svgs.forEach((svg) => {
expect(svg).toHaveAttribute("aria-hidden", "true");
});
});

it("reloads the page when 'Reload Page' button is clicked", () => {
const reloadMock = vi.fn();

Expand Down
Loading