🛡️ Sentinel: [security improvement] use dangerouslySetInnerHTML for JSON-LD script - #159
google-labs-jules[bot] wants to merge 1 commit into
Conversation
…SON-LD script
🚨 Severity: LOW
💡 Vulnerability: Direct interpolation of JSON-LD string as child of `<script>` tag can cause React escaping/hydration issues or unintentional execution parsing depending on the React version rendering model.
🎯 Impact: Minor runtime warnings/errors in React or potential broken structured data. XSS is already mitigated by `safeJsonLdStringify`.
🔧 Fix: Updated the tag to use React's idiomatic `dangerouslySetInnerHTML={{ __html: JSON_LD_STRING }}`.
✅ Verification: Ran unit tests and lint checks. No regressions found.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
Superseded by #161 |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
This branch was successfully deployed
1 participant
🚨 Severity: LOW
💡 Vulnerability: Direct interpolation of JSON-LD string as child of
<script>tag can cause React escaping/hydration issues or unintentional execution parsing depending on the React version rendering model.🎯 Impact: Minor runtime warnings/errors in React or potential broken structured data. XSS is already mitigated by
safeJsonLdStringify.🔧 Fix: Updated the tag to use React's idiomatic
dangerouslySetInnerHTML={{ __html: JSON_LD_STRING }}.✅ Verification: Ran unit tests and lint checks. No regressions found.
PR created automatically by Jules for task 8777147705105559934 started by @amrabed