Skip to content

Add michelin tms#1522

Merged
Ernst79 merged 10 commits intocustom-components:masterfrom
Gr3G63:add_michelin_tms
Mar 21, 2026
Merged

Add michelin tms#1522
Ernst79 merged 10 commits intocustom-components:masterfrom
Gr3G63:add_michelin_tms

Conversation

@Gr3G63
Copy link
Copy Markdown
Contributor

@Gr3G63 Gr3G63 commented Jan 27, 2026

Hi,

I am currently working at Michelin (the tire company).
We are developing a TMS (Tire Mounted Sensor) that measures temperature and pressure inside a tire.
The sensors communicate via BLE advertising.

I would like to add support for these sensors in your Home Assistant add-on.

support frame type 0x03
support frame type 0x03
@Gr3G63 Gr3G63 marked this pull request as draft January 27, 2026 10:22
@Gr3G63 Gr3G63 marked this pull request as ready for review January 30, 2026 15:07
'XMOSB01XS' : 'Xiaomi',
'RS1BB' : 'Linptech',
'ES3' : 'Linptech',
'TMS' : 'MICHELIN',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'TMS' : 'MICHELIN',
'TMS' : 'Michelin',

'ST10' : 'MOCREO',
'MS1' : 'MOCREO',
'MS2' : 'MOCREO',
'TMS' : 'MICHELIN',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'TMS' : 'MICHELIN',
'TMS' : 'Michelin',

Copy link
Copy Markdown
Collaborator

@Ernst79 Ernst79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. One minor suggestion. I think the company name should be spelled lowercase, as we do for other brands as well. Only if the brand name is really all in capital, we can allow this.

Fix test_michelin.py
@Gr3G63
Copy link
Copy Markdown
Contributor Author

Gr3G63 commented Mar 9, 2026

Hi Ernst79,
Thanks for your approval !
I have applied your suggestion and fixed the test file !

Copy link
Copy Markdown
Collaborator

@Ernst79 Ernst79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Ernst79 Ernst79 merged commit 46cb9ee into custom-components:master Mar 21, 2026
6 checks passed
@Gr3G63
Copy link
Copy Markdown
Contributor Author

Gr3G63 commented Mar 23, 2026

Many thanks !!

@Gr3G63 Gr3G63 deleted the add_michelin_tms branch March 23, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants