Fix struct.error on malformed Xiaomi 0x4851/0x4852 payloads#1535
Merged
Ernst79 merged 1 commit intocustom-components:masterfrom Mar 22, 2026
Merged
Conversation
Ernst79
approved these changes
Mar 22, 2026
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents
struct.error: unpack requires a buffer of 4 bytesfor malformed Xiaomi duration objects.Changes:
obj4851against invalid payload lengths (len(xobj) != 4)obj4852against invalid payload lengths (len(xobj) != 4)When malformed payloads are received, the parser now safely returns
{}instead of raising.Linked issues
Fixes #1534
Related to #1504
Validation
python -m py_compile custom_components/ble_monitor/ble_parser/xiaomi.pypytest custom_components/ble_monitor/test/test_xiaomi_parser.py -k 'obj4851 or obj4852' -q4 passed