Repository navigation
fix(web): tie the privacy copy to who can read each space - #400
Merged
Merged
Conversation
A memberspace policy can make a space publicly readable, so data is not private just because it sits in a space. The booking details hint, the about and sign-in pages, the footer and the READMEs now say who can read each kind of data. The privacy page says Local Network hosts and indexes booking threads, and covers act, party and venue spaces. Part of LOC-157.
bnb
previously approved these changes
Nov 2, 2026
Coverage Report for apps/web
File Coverage
SizeCompared with main. KiB are 1,024 bytes.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
# Conflicts: # apps/web/src/routes/login/+page.svelte
bnb
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A memberspace policy can make a space publicly readable (
publicRead), so data isn't private just because it sits in a space. Each space's read policy is what keeps ours private. This changes the web app's copy to say who can read things.apps/web/README.md: the intro uses the same read policy wording, and the act, party and venue rows say staff read those spaces through the app, since staff aren't members. The root README's app row says "member-only spaces".Part of LOC-157.
How it was tested
apps/web:pnpm verifyandpnpm test:coverage(94.25% statements, 84.56% branches, 94.55% functions, 95.7% lines, all above the thresholds).pnpm exec ast-grep test --skip-snapshot-tests,pnpm exec ast-grep scanandtools/policy.sh./privacy,/about,/login, the footer and the new project form onpnpm devat 390 and 1280 px wide, signed in as neon.test for the form.No tests added: the change is copy only.
Earlier exposure of private booking details
Until 2026-11-02 02:43 UTC, the root's industry space, which holds projects' private booking details, had a public read policy. Before #329 the app created it that way on purpose. Under the 10-22 spaces alpha that let any signed-in atproto account read it. Under the 10-29 alpha the same policy is
publicRead: true, which has the host issue a read credential to anyone who asks. #329 changed the code to staff-only, but the startup bootstrap only created missing spaces and never corrected an existing space's policy. #379 added that correction. Its deploy loggedcorrected root space policiesfor the industry space (publicReadfromtruetofalse) at 02:43:55 UTC, and the space has been staff-only since.Checklist
docs/and--helpstill say what the code does