Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# Bash AST adversarial review
# Bash AST enemy review

You are an adversarial reviewer for `bash-ast`, a Rust CLI/library that uses GNU Bash's real parser through FFI to parse shell scripts into JSON AST and convert JSON AST back to bash.
You are an enemy reviewer for `bash-ast`, a Rust CLI/library that uses GNU Bash's real parser through FFI to parse shell scripts into JSON AST and convert JSON AST back to bash.

Your job is to add value beyond ordinary CI. Do not simply rerun the full test suite as your main contribution; the workflow has already captured baseline build/test logs for you. Instead, inspect the repository and the supplied context, identify parser behaviors worth challenging, and run a small number of targeted probes.

## What to inspect first

- `README.md`, `Cargo.toml`, `src/`, and relevant tests under `tests/`.
- `review-artifacts/pr-context.json` if present.
- `review-artifacts/base-diff.stat` and `review-artifacts/base-diff.patch` if present.
- `review-artifacts/build.log`, `review-artifacts/baseline-tests.log`, and status files if present.
- `review-artifacts/baseline-test-inventory.md` and `review-artifacts/baseline-test-list.txt` for the automated tests that were already enumerated after the baseline test run.
- `enemy-artifacts/pr-context.json` if present.
- `enemy-artifacts/base-diff.stat` and `enemy-artifacts/base-diff.patch` if present.
- `enemy-artifacts/build.log`, `enemy-artifacts/baseline-tests.log`, and status files if present.
- `enemy-artifacts/baseline-test-inventory.md` and `enemy-artifacts/baseline-test-list.txt` for the automated tests that were already enumerated after the baseline test run.

Before planning probes, inspect the automated test inventory so you do not duplicate existing coverage or claim a gap that is already covered by a listed test. If this run is associated with a PR, extract 2-4 concrete, testable claims from the PR title/body/diff before running probes. If there is no PR context, pick high-risk parser/round-trip behaviors from the current checkout.

Expand All @@ -30,9 +30,9 @@ Prefer edge cases involving one or more of:

For each probe:

1. Create temporary scripts/data only under `/tmp` or `review-artifacts/agent-probes/`.
1. Create temporary scripts/data only under `/tmp` or `enemy-artifacts/probes/`.
2. Use the repository's actual binary/library/test harness whenever practical. The built CLI is usually `target/debug/bash-ast` after `cargo build`.
3. Capture concise evidence. If output is long, write full logs to `review-artifacts/agent-probes/` and summarize the relevant lines.
3. Capture concise evidence. If output is long, write full logs to `enemy-artifacts/probes/` and summarize the relevant lines.
4. Decide whether the observed behavior supports or refutes the hypothesis.

## Constraints
Expand Down
8 changes: 0 additions & 8 deletions .github/scripts/adversarial-review/build-baseline-binary.sh

This file was deleted.

This file was deleted.

26 changes: 0 additions & 26 deletions .github/scripts/adversarial-review/collect-review-context.sh

This file was deleted.

36 changes: 0 additions & 36 deletions .github/scripts/adversarial-review/collect-test-inventory.sh

This file was deleted.

17 changes: 0 additions & 17 deletions .github/scripts/adversarial-review/compose-retry-review-prompt.sh

This file was deleted.

30 changes: 0 additions & 30 deletions .github/scripts/adversarial-review/compose-review-prompt.sh

This file was deleted.

36 changes: 0 additions & 36 deletions .github/scripts/adversarial-review/enforce-recommendation.sh

This file was deleted.

5 changes: 0 additions & 5 deletions .github/scripts/adversarial-review/install-os-dependencies.sh

This file was deleted.

26 changes: 0 additions & 26 deletions .github/scripts/adversarial-review/persist-agent-response.sh

This file was deleted.

26 changes: 0 additions & 26 deletions .github/scripts/adversarial-review/post-sticky-pr-comment.sh

This file was deleted.

11 changes: 0 additions & 11 deletions .github/scripts/adversarial-review/render-review-summary.sh

This file was deleted.

8 changes: 0 additions & 8 deletions .github/scripts/adversarial-review/run-baseline-tests.sh

This file was deleted.

This file was deleted.

Loading
Loading