Repository navigation
Use upstream depth costs with log-scale optimization - #49
Draft
Zador-Pataki wants to merge 2 commits into
Draft
Zador-Pataki wants to merge 2 commits into
Zador-Pataki wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VidMap maintains its own GP and BA depth residuals. The proposed COLMAP depth appenders and cost functors provide these operations with log-scale inputs, allowing VidMap to remove the duplicated residual implementations.
Changes
6cde3c7f.GP's log-scale regularization and upstream transition and uncertainty handling intentionally change its objective. BA retains its intended objective. Existing warmup and center initialization are unchanged.
Dependency
Pending dependency: this draft pins an unpublished COLMAP depth implementation (
6cde3c7f). Public builds are blocked until that implementation is published and the pin is updated. Validation against the final dependency revision is also pending.