Skip to content

[-] apply non-recursive yaml dir reading, fixes #1368#1382

Merged
pashagolub merged 4 commits intomasterfrom
1368-fix-YAML-folder-load
Apr 30, 2026
Merged

[-] apply non-recursive yaml dir reading, fixes #1368#1382
pashagolub merged 4 commits intomasterfrom
1368-fix-YAML-folder-load

Conversation

@pashagolub
Copy link
Copy Markdown
Collaborator

replace WalkDir with filepath.Glob, those functions never intended to be recursive in the first place

@pashagolub pashagolub self-assigned this Apr 29, 2026
@pashagolub pashagolub added the bug Something isn't working label Apr 29, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 29, 2026

Coverage Report for CI Build 25167206786

Coverage increased (+0.2%) to 84.533%

Details

  • Coverage increased (+0.2%) from the base build.
  • Patch coverage: 5 uncovered changes across 2 files (16 of 21 lines covered, 76.19%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
internal/sources/yaml.go 10 7 70.0%
internal/metrics/yaml.go 11 9 81.82%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 5334
Covered Lines: 4509
Line Coverage: 84.53%
Coverage Strength: 0.97 hits per line

💛 - Coveralls

Comment thread internal/metrics/yaml.go Outdated
Comment thread internal/sources/yaml.go Outdated
replace `WalkDir` with `filepath.Glob`, those functions never intended
to be recursive in the first place
@pashagolub pashagolub force-pushed the 1368-fix-YAML-folder-load branch from 1a839d9 to 49623c9 Compare April 30, 2026 12:27
@pashagolub pashagolub merged commit facf5c1 into master Apr 30, 2026
8 checks passed
@pashagolub pashagolub deleted the 1368-fix-YAML-folder-load branch April 30, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directory-based YAML source loading reads hidden Kubernetes mount internals and causes duplicate sources

3 participants