Skip to content

ci: run the publish gate on release, not on the version PR #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unional merged 1 commit into from
Aug 31, 2026
Merged

ci: run the publish gate on release, not on the version PR #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,3 @@ jobs:
with:
os: '["ubuntu-latest"]'
skip-playwright: true

publish-gate:
if: startsWith(github.head_ref, 'changeset-release/')
uses: cyberuni/.github/.github/workflows/pnpm-publish-gate.yml@main
permissions:
contents: read
15 changes: 14 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,22 @@ jobs:
os: '["ubuntu-latest"]'
skip-playwright: true

# Runs on the default branch immediately before `changeset publish`, so a tarball that
# trips the gate blocks the release. It used to sit on the changesets "Version
# Packages" PR instead, where it could never fire: a PR opened with the built-in
# GITHUB_TOKEN does not trigger `on: pull_request`, so that PR gets zero checks and
# the job attached to it was never once executed.
#
# A `needs:` of release, so it also runs on pushes that only open or update the
# Version PR rather than publish. Deliberate — it fails closed.
publish-gate:
uses: cyberuni/.github/.github/workflows/pnpm-publish-gate.yml@main
permissions:
contents: read

release:
uses: cyberuni/.github/.github/workflows/pnpm-release-changeset-oidc.yml@main
needs: code
needs: [code, publish-gate]
permissions:
id-token: write
contents: write
Expand Down
Loading