Issue #6 : Add Namespace and Probes Configuration to Kubernetes Manifests by RohanRusta21 · Pull Request #7 · cyclops-ui/templates

RohanRusta21 · 2024-04-28T19:59:29Z

This pull request focuses on the addition of new fields within various files, namely "deployment.yaml", "services.yaml", "values.schema.json", and "values.yaml". Here's a summary of the changes made:

In "demo-extended/templates/deployment.yaml", I have introduced YAML code for Namespace and Probes (specifically, readinessProbe, livenessProbe, and startupProbe). The default values for these fields are retrieved from "values.yaml".
Within "demo-extended/templates/services.yaml", I have incorporated YAML code for Namespace. Similar to the deployment template, the default values for these fields are sourced from "values.yaml".
In "demo-extended/values.schema.json", I have extended the JSON schema to include the Namespace field below Name, which falls under the metadata of deployment.yml. Additionally, I have structured a separate, expandable section for Probes, allowing users to conveniently review and customize each probe as needed.
Within "demo-extended/values.yaml", default values have been provided for the newly added fields in the branch, along with resources (CPU and memory), which were previously declared but lacked default values.

Please Review the PR and feel free to contact me if any improvement required from my end 👍 ,

Thanks & Regards,
Rohan Rustagi

petar-cvit

Thanks @RohanRusta21! Could you also add a description to the newly added fields

demo-extended/values.schema.json

petar-cvit · 2024-05-02T19:01:56Z

demo-extended/values.schema.json

+            }
+          }
+        },
+        "readiness": {


Can you add order: ["path", "initialDelaySeconds"...]

Hey @petar-cvit , Yup its done now. Please Review it :)

petar-cvit · 2024-05-04T20:42:41Z

demo-extended/templates/deployment.yaml

-            - name: {{ $key }}
-              value: {{ $value | quote }}
+          {{- if .Values.general.environment }}
+          {{- toYaml .Values.general.environment | indent 12 }}


Can you revert this? With the UI for env variables, the indent doesn't work

petar-cvit · 2024-05-04T20:43:14Z

demo-extended/values.schema.json

+        }
+      },
+      "order": [
+        "enabled",


can we add enabled to each probe separately? Also can you make it disabled by default in values.yaml

Hi @petar-cvit , actually initially I tried to have separate toggle for each probe. But it was not working fine. Maybe will try it again.

Please do. You can paste the error here if you want and we can try to figure it out

Can you explain me this error.

UI changes performed :

We refactored manifest rendering so you can try out the template again with the updated version.

petar-cvit · 2024-07-22T15:39:27Z

demo-extended/templates/deployment.yaml

  labels:
    app: {{ .Values.name }}
 spec:
-  replicas: {{ (.Values.scaling).replicas | default 1 }}


Can we leave this default?

petar-cvit · 2024-07-22T15:39:31Z

demo-extended/templates/deployment.yaml

        - name: {{ .Values.name }}
          image: "{{ .Values.general.image }}:{{ .Values.general.version }}"
-          {{- if ((.Values.networking).expose) }}
+


Could you remove all empty lines?

petar-cvit · 2024-07-22T15:43:22Z

demo-extended/templates/deployment.yaml

          ports:
            - name: http
-              containerPort: {{ .Values.networking.port | default 80 }}
+              containerPort: {{ .Values.networking.port }}


What happens if port is not set? We cant enforce it since exposing is optional

Yeah but this template is meant to expose the port specified by the user.

petar-cvit · 2024-07-22T15:44:04Z

demo-extended/templates/deployment.yaml

          {{- if or ((.Values.scaling).resources).memory ((.Values.scaling).resources).cpu }}
+
          resources:
-            {{- if ((.Values.scaling).resources).memory }}


Can you rever the resources object since its not format properly and it can cause a null pointer because of deleted brackets

petar-cvit · 2024-07-22T15:47:01Z

demo-extended/templates/deployment.yaml

+              cpu: "{{ .Values.scaling.resources.cpu }}"
            {{- end }}
+
+          {{- if .Values.probes.enabled }}


Can you add brackets the same way it was done in the resources object to avoid null objects

petar-cvit · 2024-07-22T15:47:47Z

demo-extended/values.schema.json

+        }
+      },
+      "order": [
+        "enabled",


We refactored manifest rendering so you can try out the template again with the updated version.

petar-cvit · 2024-07-23T08:39:29Z

@RohanRusta21, you also have some conflicts that need to be resolved. We renamed the chart since this PR was opened

RohanRusta21 added 6 commits April 25, 2024 11:06

"Added code for Probes & Namespace"

9f6b9bd

Update values.yaml

647f337

Update values.schema.json

931e99a

Update Chart.yaml

d39a512

Update deployment.yaml

d421355

Update Chart.yaml

ab32e68

petar-cvit requested a review from a team April 29, 2024 19:47

petar-cvit requested changes Apr 29, 2024

View reviewed changes

demo-extended/values.schema.json Show resolved Hide resolved

demo-extended/values.schema.json Show resolved Hide resolved

RohanRusta21 added 7 commits May 2, 2024 23:45

Update values.schema.json

b2e54fd

Update values.schema.json

01d71e2

Update values.yaml

bb69782

Update values.schema.json

4ef0a98

Update values.yaml

ba98d11

Update values.yaml

7234332

Update values.schema.json

b9f58e6

RohanRusta21 requested a review from petar-cvit May 2, 2024 18:54

petar-cvit requested changes May 2, 2024

View reviewed changes

RohanRusta21 added 2 commits May 3, 2024 00:52

Update values.schema.json

a8df846

Update deployment.yaml

d0364ac

petar-cvit requested changes May 4, 2024

View reviewed changes

RohanRusta21 added 10 commits May 5, 2024 19:41

Updated deployment.yaml for env

d1b7e62

Update values.yaml

4203578

Update values.schema.json

9630037

Update values.schema.json

c9d7c60

Update values.schema.json

42a31a4

Update values.schema.json

91b183c

Update values.yaml

9ea3325

Update values.schema.json

bf9ab27

Update Chart.yaml

312d157

Update deployment.yaml

bfcf826

petar-cvit requested changes Jul 22, 2024

View reviewed changes

modified deployment,values.yaml,schema json

e987067

Conversation

RohanRusta21 commented Apr 28, 2024

Uh oh!

petar-cvit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petar-cvit commented Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants