Skip to content

GetCookieManager sometimes not called due to a race condition. API removed in latest CEF. #429

Open
Open
GetCookieManager sometimes not called due to a race condition. API removed in latest CEF.#429
Labels
API removedBC break!bugnext release
Milestone
v66

Description

@cztomczak
cztomczak
opened on May 22, 2018

The GetCookieManager callback doesn't have browser parameter in upstream CEF. This param is set during synchronous browser creation in CreateBrowserSync [1], so it is not immediately available. See comment in request context handler in C++ [2] and the SetBrowser method. Fix needs to be applied in [3] with such code:

if cefBrowser.get():
    pyBrowser = GetPyBrowser(cefBrowser, "GetCookieManager")
else:
    pyBrowser = None

And app code needs to be aware that browser param in GetCookieManager may be None - API docs need to state that.

Issue originally reported on the forum:
https://groups.google.com/d/msg/cefpython/e3bFx1I5BZA/2ZM7jKk8AgAJ

Ref:
[1]

cefpython/src/cefpython.pyx

Line 908 in ebdb184

# Request context - part 2/2.

[2]

cefpython/src/client_handler/request_context_handler.h

Line 21 in 824d7ce

// Browser may be NULL when instantiated from cefpython.CreateBrowserSync.

[3]

cefpython/src/handlers/request_handler.pyx

Line 281 in 77c506b

cdef public CefRefPtr[CefCookieManager] RequestHandler_GetCookieManager(

Activity

  1. cztomczak
    added
    bug
    next release
    on May 22, 2018
  2. cztomczak
    added this to the v66 milestone on May 22, 2018
  3. jakogut
    added 2 commits that reference this issue on May 22, 2018

    RequestHandler: fix GetCookieManager: CefBrowser reference is NULL

    d299fcd

    RequestHandler: fix GetCookieManager: CefBrowser reference is NULL

    ee4d8a2

  4. cztomczak commented on May 25, 2018

    @cztomczak
    cztomczak
    on May 25, 2018
    OwnerAuthor

    This error happened to me as well when running wxpython.py example.

  5. cztomczak
    added a commit that references this issue on May 25, 2018

    Fix GetCookieManager 'browser' param NULL exception (#429)

    c546957
  6. cztomczak
    closed this as completedon May 25, 2018
  7. cztomczak
    added a commit that references this issue on May 25, 2018

    Update GetCookieManager bug and reopen issue (#429)

    c599c59
  8. cztomczak
    changed the title [-]RequestHandler_GetCookieManager throws "Exception: GetCookieManager: CefBrowser reference is NULL" w/ CEF 65.0+[/-] [+]GetCookieManager sometimes not called due to a race condition[/+] on May 25, 2018

  9. cztomczak commented on May 25, 2018

    @cztomczak
    cztomczak
    on May 25, 2018
    OwnerAuthor

    Fixing the error is not enough, because if browser is NULL then we can't call user callback, as it is assigned to that browser. It must be fixed so that GetCookieManager callback is always called.

  10. cztomczak
    reopened this on May 25, 2018
  11. cztomczak
    added
    BC break!
    API removed
    on Jan 23, 2020
  12. cztomczak
    changed the title [-]GetCookieManager sometimes not called due to a race condition[/-] [+]GetCookieManager sometimes not called due to a race condition. API removed in latest CEF.[/+] on Jan 23, 2020

  13. cztomczak commented on Jan 23, 2020

    @cztomczak
    cztomczak
    on Jan 23, 2020
    OwnerAuthor

    The GetCookieManager API was removed from upstream CEF. You can no longer create an instance on CefCookieManager, instead you have to create a new instance of CefRequestContext and provide a different cache_path to have a separate cookie store. This and other NetworkService related changes were disucced in upstream: https://bitbucket.org/chromiumembedded/cef/issues/2622/implement-support-for-networkservice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    API removedBC break!bugnext release

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions