Repository navigation
Conversation
…add definitions with union `ZarrV3Context.update(**slots)` and `ZarrV2Context.update(**slots)` read as a merge, but replace each slot whole, so passing one new definition silently dropped every default. They become `copy(*, update=None)`, after pydantic's `model_copy(update=...)`, whose replace-whole meaning pydantic users already know. Adding definitions is `union`, which keeps every definition the scope has and refuses a conflicting one; the docs, docstrings and call sites now use it instead of splicing a slot's definitions back in. Fixes #424 Assisted-by: ClaudeCode:claude-opus-5-5
…ts PR Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Replace
ZarrV3Context.update(**slots)andZarrV2Context.update(**slots)withcopy(*, update=None), after pydantic'smodel_copy(update=...):context.update(codecs=[...])becomescontext.copy(update={"codecs": [...]}), and still replaces each slot it is given whole. To add definitions to a scope and keep the ones it has, useunion:CORE_AND_EXTENSIONS.union(ZarrV3Context(data_types=[MY_DATA_TYPE])), which the docs now show in place of splicing a slot's definitions back in.Fixes #424.
copy's docstring warns thatcopy(update={"codecs": [X]})leavesXas the only codec and points atunion; the docstrings ofunion, the scope classes and thedefinitionpackage overview nameunionas the way to add definitions.CORE_AND_EXTENSIONSis now built withCORE.union(...). About 50 test call sites moved: splices of a slot's own definitions becameunion, and replacements by name becamecopy(update=...).test_union_adds_definitions_and_keeps_every_one_the_scope_has, covers the case in the issue.ZarrV3ArrayMetadataand friends) keep their ownupdate(**members), which has the same replace-whole meaning. The agent left them alone, so the two operations now have different names.just checkinpackages/zarr-metadatapasses: ruff, pyright, the tests on Python 3.11 and the newest supported version, and the strict docs build.🤖 Generated with Claude Code