Repository navigation
Conversation
A column's label defaults to its name, so compileSQLTable blanked the type whenever the two matched, including when the label was set explicitly (date: date). Record explicit labels and only blank the type when there is none. Fixes d2lang#1960
A class field or method label defaults to its name, so compileClass dropped the field type, or replaced the return type with void, whenever the two matched, including when the label was set explicitly (date: date). Only fall back when there is no explicit label. Fixes d2lang#2951
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2951
Stacked on #2950: the first two commits belong to it, the rest are this PR's.
date: datein ashape: classrendered the field with an empty type, andnow(): now()rendered the method returningvoid.compileClasshad thesame check #2950 changes for
sql_tablecolumns.The first commit moves the explicit label lookup from #2950 into a
hasExplicitLabelhelper. The second uses it incompileClass. Fields andmethods without a label still render with no type and
void.