Conversation
…/ submodule
Lift Go module into go/ subtree for cross-language repo symmetry (matches
core/api v0.12.0 shape). Module path stays dappco.re/go/build — consumers
see no change. Adds go.work + external/go submodule for dev workspace mode;
CI uses GOWORK=off (already set in .woodpecker.yml).
Moved into go/:
- go.mod, go.sum
- cmd/, pkg/, internal/, tests/, locales/ (locales/embed.go imports as a Go
package so must live inside the module)
Stays at repo root:
- README.md, CLAUDE.md, AGENTS.md, LICENSE, sonar-project.properties,
.woodpecker.yml, docs/, ui/
Symlinks: go/{README,CLAUDE,AGENTS}.md + go/docs → ../
Pre-existing failure (NOT caused by restructure):
- pkg/service TestDaemon_Run_{Good,Bad,Ugly} fails with gin handler
re-registration panic on shared router — test isolation issue.
Tracked as separate concern.
Verification:
- go mod tidy clean (GOWORK=off)
- go vet ./... clean
- go test pass for pkg/storage; pre-existing pkg/service flake noted above
- audit COMPLIANT
Mechanical fixes across cmd/, internal/, pkg/. errcheck wrapping for
unchecked returns, removal of unused stdlib_assert aliases (declared
but never referenced), staticcheck modernisations.
Test files DID get touched in this lane (brief was the older version
without the skip-tests rule) — but the changes are safe: deleting
unused vars + wrapping ignored returns in `_ =`. No behaviour changes,
no test-intent breakage.
Pre-existing failure unchanged:
- pkg/service TestDaemon_Run_{Good,Bad,Ugly} still panic with gin
"handlers already registered for path /api/v1/build/events" —
that's a test-isolation bug from the restructure, not from this lane.
Tracked separately.
Mirrors api shape: .github/workflows/ci.yml runs test+coverage (Codecov), golangci-lint --tests=false, and sonarcloud-scan-action to dappcore_go-build. README gets the badge block (CI / quality gate / cov / security / maintainability / reliability / smells / NCLOC / pkg.go.dev / license). GOPROXY=direct GOSUMDB=off env in workflow to dodge the proxy.golang.org stale-zip pattern that broke api's first run. Internal Woodpecker pipeline at ci.lthn.sh continues unchanged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routine dev→main promotion as part of cross-repo top-down dep tree sweep so module-tidy can resolve current versions across consumers.