Conversation
…tis #1226)
Convert command-registration helpers from discarding c.Command(...)
Result via `_ = c.Command(...)` to propagating failures via
`if r := c.Command(...); !r.OK { return r }`. Caller signature
changes from `func AddCICommands(c *core.Core)` to
`func AddCICommands(c *core.Core) core.Result`.
Also replaces remaining core.Errorf routing with core.E to match the
canonical core/go primitive.
Audit (audit.sh) findings: 1311 → 1297 (-14 result-discards). Other
dimensions untouched. 0 gaming patterns. Build, vet, test all clean.
Closes tasks.lthn.sh/view.php?id=1226
Co-authored-by: Codex <noreply@openai.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings v0.14.0 to main: refactor(go) propagating command-registration Result + core.E. Audit: 1311 → 1297 (-14 result-discards). Closes Mantis #1226.