This repository was archived by the owner on Sep 24, 2020. It is now read-only.
Large cleanup of code, comments, and data race fixes. - #1
Open
iwasaki-kenta wants to merge 3 commits into
Open
Conversation
build: add go:generate script to build protobufs erasurecode: move plugin components into `erasurecode` package erasurecode: added comments and fixed race condition for loading/instantiating in-memory shard pool erasurecode: simplified var names and improved error handling erasurecode: use github.com/pkg/errors protobuf: removed gogo options set main: add comments to explain largest prime factoring for min/total required shards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made code closer to Go code standards, and fixed a few issues/data races.
dep: instantiate as go module
build: add go:generate script to build protobufs
erasurecode: move plugin components into
erasurecodepackageerasurecode: added comments and fixed race condition for loading/instantiating in-memory shard pool
erasurecode: simplified var names and improved error handling
erasurecode: use github.com/pkg/errors
protobuf: removed gogo options set
main: add comments to explain largest prime factoring for min/total required shards