feat: adopt pre-existing values.schema.json for dependency charts#202
Merged
dadav merged 1 commit intodadav:mainfrom Mar 30, 2026
Merged
feat: adopt pre-existing values.schema.json for dependency charts#202dadav merged 1 commit intodadav:mainfrom
dadav merged 1 commit intodadav:mainfrom
Conversation
Dependency charts that ship with their own values.schema.json are now used as-is instead of regenerating from values.yaml. This preserves rich constraints, descriptions, and custom x-* annotations from third-party charts. Also fixes UnmarshalJSON to extract x-* custom annotations and track explicit const fields, matching the existing UnmarshalYAML behavior.
Contributor
Author
|
PR with a bit of help from Claude. Backstory: I tried to add a schema for a chart that has a dependency chart, that comes with its own schema, not generated with helm-schema. When helm-chart generates the schema it makes it more strict than the existing schema, leaving some options unconfigurable. With this PR the existing, presumably valid schema is preferred over creating our own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependency charts that ship with their own values.schema.json are now used as-is instead of regenerating from values.yaml. This preserves rich constraints, descriptions, and custom x-* annotations from third-party charts.
Also fixes UnmarshalJSON to extract x-* custom annotations and track explicit const fields, matching the existing UnmarshalYAML behavior.