fix(lance): drop dead floor-division of num_groups in distribute_fragments_balanced#12
Merged
universalmind303 merged 1 commit intoJun 3, 2026
Conversation
Contributor
Author
|
hi @colin-ho, I've submitted a fix PR for this in daft-lance: https://github.com/XuQianJin-Stars/daft-lance/pull/new/fix/lance-utils-redundant-num-groups It removes the redundant floor-division line as you suggested. Could you please take a look when you get a chance? Thanks! |
|
@rchowell can you take a look? I'm not a maintainer :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove a redundant floor-division assignment of
num_groupsindistribute_fragments_balanced(daft_lance/utils.py).Why
The first assignment:
python num_groups = max(1, len(fragments) // fragment_group_size)is immediately overwritten by the correct ceiling-division on the very next line:
python num_groups = max(1, (len(fragments) + fragment_group_size - 1) // fragment_group_size)This makes the floor-division line dead code with no observable effect. Removing it improves readability and eliminates potential confusion about which formula is actually used.
Changes
num_groups = max(1, len(fragments) // fragment_group_size)line indaft_lance/utils.py.