Skip to content

feat: add full-text search (FTS) support via full_text_query in read_lance()#19

Open
Lucas61000 wants to merge 1 commit into
daft-engine:mainfrom
Lucas61000:issue-15
Open

feat: add full-text search (FTS) support via full_text_query in read_lance()#19
Lucas61000 wants to merge 1 commit into
daft-engine:mainfrom
Lucas61000:issue-15

Conversation

@Lucas61000
Copy link
Copy Markdown

@Lucas61000 Lucas61000 commented Jun 2, 2026

Changes Made

  • _lancedb_table_factory_function: accept full_text_query param, pass to both fragment-based and global ds.scanner() calls
  • LanceDBScanOperator: add _resolve_full_text_query() to extract FTS option from default_scan_options at init time; forward through to_scan_tasks
  • Skip limit-only fast path when FTS is active (FTS is semantically a filter)
  • Use index-driven scan (fragment_ids=None) when FTS is active, consistent with nearest behavior
  • construct_lance_dataset: strip full_text_query from default_scan_options passed to lance.dataset() to prevent leaking as persistent default
  • Update stale TODO comment

Related Issues

Closes #15

…lance()

- _lancedb_table_factory_function: accept full_text_query param, pass to both
  fragment-based and global ds.scanner() calls
- LanceDBScanOperator: add _resolve_full_text_query() to extract FTS option
  from default_scan_options at init time; forward through to_scan_tasks
- Skip limit-only fast path when FTS is active (FTS is semantically a filter)
- Use index-driven scan (fragment_ids=None) when FTS is active, consistent
  with nearest behavior
- construct_lance_dataset: strip full_text_query from default_scan_options
  passed to lance.dataset() to prevent leaking as persistent default
- Update stale TODO comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Support full-text search (FTS) in read_lance()

1 participant