simplify display of RulesFor variants - #660
Merged
NSoiffer merged 1 commit intoAug 11, 2026
Merged
Conversation
…`fmt::Display` implementation
Collaborator
|
Looks good. I'm surprised that there aren't other places that can take advantage of that macros (or that it is not built-in). |
Collaborator
Author
there are multiple places that are close this, but not exactly fitting. For example fmt of Another case is "sapi5" for I could just make PRs based on what looks the cleanest and most consistent to me and then you can judge if it should be changed ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a small simplification using the strum crate that we already have.