use strum_macros::Display for Token - #666
Closed
moritz-gross wants to merge 1 commit into
Closed
Conversation
NSoiffer
reviewed
Aug 11, 2026
NSoiffer
left a comment
NSoiffer
left a comment
Collaborator
There was a problem hiding this comment.
I'm not that happy with this change. I think it makes reading the enum much harder for a minor drop in the total number of lines.
Do you want to provide a counter argument?
Collaborator
Author
|
hm ideally there'd be a syntax like name_of_enum_variant + string, that you specify only once. when I find a solution that I'm really happy with, I'll open another PR for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ok I forgot that you also need to reuse
strin the display-string, so this makes it a bit longer than I thought it would be.still, that's a 9 line improvement, and it keeps the logic closer by having it directly next to each variant, instead of an extra function.
in my book, this is still worth doing