FEATURE: add include check to force user to maintain include order#6
Open
dan-42 wants to merge 1 commit intodaminetreg:feature/mapbox-variantfrom
Open
FEATURE: add include check to force user to maintain include order#6dan-42 wants to merge 1 commit intodaminetreg:feature/mapbox-variantfrom
dan-42 wants to merge 1 commit intodaminetreg:feature/mapbox-variantfrom
Conversation
Contributor
Author
|
works just found another issue in ninja wookie Scanning dependencies of target wookie
[ 1%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/service/service/detail/service_grammar.cpp.o
[ 2%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/apdu/frame/grammar.cpp.o
[ 3%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/npdu/detail/grammar.cpp.o
[ 5%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/bvll/frames.cpp.o
[ 6%] Building CXX object src/CMakeFiles/wookie.dir/bacnet/npdu/frame.cpp.o
In file included from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/frames.hpp:29:0,
from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.hpp:26,
from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.cpp:24:
/home/frieddan/git/ninja-wookie/src/mapbox/boost_spirit_qi.hpp:9:4: error: #error "ERROR file must be included before boost spirit qi"
#error "ERROR file must be included before boost spirit qi"
^
In file included from /home/frieddan/git/ninja-wookie/src/bacnet/npdu/frame.hpp:31:0,
from /home/frieddan/git/ninja-wookie/src/bacnet/npdu/detail/grammar.hpp:26,
from /home/frieddan/git/ninja-wookie/src/bacnet/npdu/detail/grammar.cpp:21:
/home/frieddan/git/ninja-wookie/src/mapbox/boost_spirit_qi.hpp:9:4: error: #error "ERROR file must be included before boost spirit qi"
#error "ERROR file must be included before boost spirit qi"
^
In file included from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/is_dereferenceable.hpp:12:0,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/resolve.hpp:26,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/push.hpp:24,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/detail/streambuf/indirect_streambuf.hpp:31,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/stream_buffer.hpp:22,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/iostreams/stream.hpp:21,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi/stream/detail/iterator_source.hpp:14,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi/stream/stream.hpp:16,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi/stream.hpp:15,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/home/qi.hpp:30,
from /home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/spirit/include/qi.hpp:16,
from /home/frieddan/git/ninja-wookie/src/bacnet/detail/common/types.hpp:15,
from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.hpp:25,
from /home/frieddan/git/ninja-wookie/src/bacnet/apdu/frame/grammar.cpp:24:
/home/frieddan/.hunter/_Base/b2c2510/d840734/f0c4777/Install/include/boost/type_traits/detail/bool_trait_def.hpp:18:79: note: #pragma message: NOTE: Use of this header (bool_trait_def.hpp) is deprecated
# pragma message("NOTE: Use of this header (bool_trait_def.hpp) is deprecated")
^
|
dan-42
pushed a commit
to dan-42/lib-cpp-pre
that referenced
this pull request
Mar 12, 2017
FEATURE: overloaded to_hexstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @daminetreg as we discussed, this will force the user to maintain include order.
I do the following,
what do you say?