docs: System One / Jev typed review layer (M11, proposed) - #38
Draft
dancingteeth wants to merge 1 commit into
Draft
dancingteeth wants to merge 1 commit into
dancingteeth wants to merge 1 commit into
Conversation
Document optional systemOne config beside verify and generative review. Clarify Jev is not reviewRuntime; OpenRouter decisions API and gate modes. Extend loop-review patterns/roadmap; add system-one-review.md sibling. Co-authored-by: Paul Zgordan <dancingteeth@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents an optional third review layer for Agent Looper: OpenRouter System One / TypeSafe Jev as typed decisions (
noul/choice/score) over fenced loop state — not areviewRuntimeor chat judge.Locked product decision: generative judges remain responsible for
review.md,reviewGateprose, Guide packets, andagent-loop-promptscaffold authorship. Jev complements verify + generative review; it does not replace them.Changes
docs/loop-review-patterns.mddocs/loop-review-roadmap.mddocs/system-one-review.mdtypesafe/jev-1.13/~typesafe/jev-latest, decisions endpoint,systemOne.gate, non-goals, contrast with shippedreviewSecondaryRuntimedocs/runtime-map.mdNo TypeScript implementation in this PR.
Alignment with shipped behavior
reviewSecondaryRuntime(M3) is still generative markdown merge.reviewGate: true→ secondary runs even on primary PASS (per current harness); System One is orthogonal.Test plan
reviewRuntime) is consistent across all four filestypesafe/jev-1.13,~typesafe/jev-latestsystemOne.gatesemantics: advisory fail-open vs block fail-closed on API/parse errorsreviewModelsystem-one-review.md, patterns §9, roadmap M11)