Fix sending of workflow completed event#1201
Open
hanna-cirilla wants to merge 2 commits intodanielgerlag:masterfrom
Open
Fix sending of workflow completed event#1201hanna-cirilla wants to merge 2 commits intodanielgerlag:masterfrom
hanna-cirilla wants to merge 2 commits intodanielgerlag:masterfrom
Conversation
…low;added test to assure behavior
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where workflows ending with an EndStep were not publishing the WorkflowCompleted lifecycle event. The issue occurred because DetermineNextExecutionTime returned early for completed workflows without sending the event.
- Extracted workflow completion event publishing into a separate method
PublishWorkflowCompleted - Added the event publication before the early return when workflow status is complete
- Added a unit test to verify the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/WorkflowCore.UnitTests/Services/WorkflowExecutorFixture.cs | Added unit test to verify WorkflowCompleted event is published when workflow ends |
| src/WorkflowCore/Services/WorkflowExecutor.cs | Fixed missing event publication by extracting PublishWorkflowCompleted method and calling it before early return |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+272
to
276
| private void PublishWorkflowCompleted(WorkflowInstance workflow) | ||
| { | ||
| _publisher.PublishNotification(new WorkflowCompleted | ||
| { | ||
| EventTimeUtc = _datetimeProvider.UtcNow, |
There was a problem hiding this comment.
The PublishWorkflowCompleted method is incomplete. The WorkflowCompleted object initialization is not closed with a closing brace and semicolon, and the method body is not properly closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
As described in #1097 a workflow that ends in an
EndStepdoes not lead to theWorkflowCompletedLifeCycleEventbeing published becauseDetermineNextExecutionTimereturns too early.This PR remedies that by sending the event also in case of an early return from
DetermineNextExecutionTime.Describe your implementation or design
Extracted publishing of
WorkflowCompletedinto a separate method and added a call to that function before the early return if workflow is completed.Tests
Yes, added a failing unit test that is green after the implementation is changed.
Breaking change
No
Additional context