Skip to content

Ignore io.WriteString results in Format#51

Merged
danieljustus merged 1 commit into
mainfrom
issue/47-update-mcp-oauth-docs
May 15, 2026
Merged

Ignore io.WriteString results in Format#51
danieljustus merged 1 commit into
mainfrom
issue/47-update-mcp-oauth-docs

Conversation

@danieljustus
Copy link
Copy Markdown
Owner

Assign io.WriteString's return values to blank identifiers in Untrusted.Format to explicitly ignore them. This silences linters/tools (e.g., errcheck) that flag unchecked return values when writing the fixed string.

What

Describe the change in a few sentences.

Why

Explain the problem, user need, or maintenance reason.

Testing

  • make fmt
  • make vet
  • make lint
  • GOWORK=off go test ./...
  • Added or updated tests where needed

Safety

  • I did not include passwords, tokens, private keys, vault contents, or personal data
  • Documentation was updated where behavior changed

Assign io.WriteString's return values to blank identifiers in Untrusted.Format to explicitly ignore them. This silences linters/tools (e.g., errcheck) that flag unchecked return values when writing the fixed string.
Copilot AI review requested due to automatic review settings May 15, 2026 10:10
@danieljustus danieljustus merged commit 712539b into main May 15, 2026
7 of 8 checks passed
@danieljustus danieljustus deleted the issue/47-update-mcp-oauth-docs branch May 15, 2026 10:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Untrusted.Format implementation used in passlint analysistest data to explicitly ignore io.WriteString return values, preventing linters (e.g., errcheck) from flagging the call as unchecked.

Changes:

  • Assign io.WriteString’s (int, error) return values to blank identifiers in Untrusted.Format to make the intentional ignore explicit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants