Use kotlin for build.gradle to use only one programming language#27
Open
lucamolteni wants to merge 1 commit intodankito:masterfrom
Open
Use kotlin for build.gradle to use only one programming language#27lucamolteni wants to merge 1 commit intodankito:masterfrom
lucamolteni wants to merge 1 commit intodankito:masterfrom
Conversation
Changed assertion method to compare HTML directly for better diffs Some tests are not working due to formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the current main doesn't work on Java 21 and on my IDEA the debugger wasn't even working, I decided to upgrade the gradle file and other libraries.
Kotlin has evolved quite a lot so I had to put some explicit field accessor with !!
I also changed assertion method to compare HTML trees directly for better diffs, but there are still 16 tests failing. Some of them are just formatting issues, but I can work on it if interested.
This somehow addresses #23