Skip to content

Remove use of leftover CMake flag USE_QT6#7748

Merged
firewave merged 2 commits intodanmar:mainfrom
gruenich:feature/cleanup-qt6
Aug 26, 2025
Merged

Remove use of leftover CMake flag USE_QT6#7748
firewave merged 2 commits intodanmar:mainfrom
gruenich:feature/cleanup-qt6

Conversation

@gruenich
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread .github/workflows/selfcheck.yml Outdated
@firewave
Copy link
Copy Markdown
Collaborator

We need to bail out in the CI on unused CMake options (by passing -Werror=dev?). I am not sure if I have not filed a ticket about this yet.

@firewave
Copy link
Copy Markdown
Collaborator

We need to bail out in the CI on unused CMake options (by passing -Werror=dev?). I am not sure if I have not filed a ticket about this yet.

I filed https://trac.cppcheck.net/ticket/14081 about that. But that cannot be easily done right now because of https://trac.cppcheck.net/ticket/14082.

@firewave
Copy link
Copy Markdown
Collaborator

firewave commented Aug 20, 2025

Unfortunately it appears you cannot fail the build on unused manually-specified variables.

@gruenich
Copy link
Copy Markdown
Contributor Author

What is the issue with 14082? It behaves as expected.

@firewave
Copy link
Copy Markdown
Collaborator

What is the issue with 14082? It behaves as expected.

It does not matter because it is outside of the scope of this.

@sonarqubecloud
Copy link
Copy Markdown

@firewave firewave merged commit 98a168b into danmar:main Aug 26, 2025
63 checks passed
@gruenich gruenich deleted the feature/cleanup-qt6 branch January 30, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants