fixed #14088 - made CMake build with BUILD_CLI=Off work#7765
Merged
firewave merged 4 commits intodanmar:mainfrom Aug 28, 2025
Merged
fixed #14088 - made CMake build with BUILD_CLI=Off work#7765firewave merged 4 commits intodanmar:mainfrom
BUILD_CLI=Off work#7765firewave merged 4 commits intodanmar:mainfrom
Conversation
Collaborator
Author
|
Still need to have a proper look at this and adjust some CI builds which should have triggered this. |
Owner
|
Thanks for working on this! This is annoying for me. |
Collaborator
Author
|
I spotted some issue with |
firewave
changed the title
BUILD_CLI=Off BUILD_GUI=Off workBUILD_CLI=Off work
Collaborator
Author
|
I actually had these changes already sitting in a branch... |
firewave
force-pushed
the
build-cli
branch
2 times, most recently
from
4d35fa9 to
50d39c7
Compare
firewave
force-pushed
the
build-cli
branch
7 times, most recently
from
57e065c to
d5aad7b
Compare
firewave
force-pushed
the
build-cli
branch
2 times, most recently
from
8b25285 to
12f0950
Compare
|
firewave
commented
Aug 26, 2025
Comment on lines
+66
to
+68
| if(NOT BUILD_CLI AND BUILD_TESTS) | ||
| message(FATAL_ERROR "Building the tests requires the CLI to be build as well") | ||
| endif() |
Collaborator
Author
There was a problem hiding this comment.
The CLI and test code are simply to intertwined to be separated so reject this combination for now.
danmar
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.