Fix unused filename parameter TODO in reportProgress#7781
Fix unused filename parameter TODO in reportProgress#7781GNL10 wants to merge 1 commit intodanmar:mainfrom
Conversation
35dc158 to
7f22b5f
Compare
|
|
Thanks for your contribution. That TODO might have been a bit overzealous (I probably added it). The progress is currently barely useful (need to look up the known shortcomings) and this would actually remove the context of the data generated. So if you were to utilize this is in a GUI and were using multiple threads/processes it would render it useless. I let somebody chime on here as well. |
|
@GNL10 thanks for looking at this. From a technical point of view this makes sense, if the parameter is not used it can be removed. |
|
Understood and agreed. I still lack the full scope of the whole project, which makes it hard to understand some of these topics. |
You are not alone. |



Deleting the filename parameter in reportProgress, since it is not used anywhere.