Skip to content

Fix unused filename parameter TODO in reportProgress#7781

Closed
GNL10 wants to merge 1 commit intodanmar:mainfrom
GNL10:fix-unused-filename-parameter-todo
Closed

Fix unused filename parameter TODO in reportProgress#7781
GNL10 wants to merge 1 commit intodanmar:mainfrom
GNL10:fix-unused-filename-parameter-todo

Conversation

@GNL10
Copy link
Copy Markdown
Contributor

@GNL10 GNL10 commented Aug 30, 2025

Deleting the filename parameter in reportProgress, since it is not used anywhere.

@GNL10 GNL10 force-pushed the fix-unused-filename-parameter-todo branch from 35dc158 to 7f22b5f Compare August 30, 2025 14:58
@GNL10 GNL10 changed the title Fix unused filename parameter in reportProgress TODO Fix unused filename parameter TODO in reportProgress Aug 30, 2025
@sonarqubecloud
Copy link
Copy Markdown

@firewave
Copy link
Copy Markdown
Collaborator

Thanks for your contribution.

That TODO might have been a bit overzealous (I probably added it). The progress is currently barely useful (need to look up the known shortcomings) and this would actually remove the context of the data generated. So if you were to utilize this is in a GUI and were using multiple threads/processes it would render it useless.

I let somebody chime on here as well.

@danmar
Copy link
Copy Markdown
Owner

danmar commented Sep 10, 2025

@GNL10 thanks for looking at this. From a technical point of view this makes sense, if the parameter is not used it can be removed.
But I feel @firewave has a good point we should probably look into how to use the progress report better. I think it would be interesting to somehow be able to see in the GUI if the analysis of a certain file has hanged.. so we should keep this parameter and then use it..

@GNL10
Copy link
Copy Markdown
Contributor Author

GNL10 commented Sep 11, 2025

Understood and agreed. I still lack the full scope of the whole project, which makes it hard to understand some of these topics.
Thanks for looking into it anyways :).

@GNL10 GNL10 closed this Sep 11, 2025
@firewave
Copy link
Copy Markdown
Collaborator

I still lack the full scope of the whole project, which makes it hard to understand some of these topics.

You are not alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants